Creates a product discount and returns it.

• Send value_type with a percentage discount. It defaults to amount_type, so a percentage alone fails.
• A discount comes off the line before tax is taken out, so it lowers the tax as well as the total.
• On recurring orders, the product's discount_for_initial_payment_only setting decides whether the discount applies to the first payment only.